Skip to content

fix: make ActClaim conform to Sendable instead of @unchecked Sendable#1237

Closed
NandanPrabhu wants to merge 1 commit into
develop/v3.0from
fix/actclaim-sendable-conformance
Closed

fix: make ActClaim conform to Sendable instead of @unchecked Sendable#1237
NandanPrabhu wants to merge 1 commit into
develop/v3.0from
fix/actclaim-sendable-conformance

Conversation

@NandanPrabhu

@NandanPrabhu NandanPrabhu commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📋 Changes

ActClaim was declared @unchecked Sendable because its additionalClaims property was typed [String: Any], and Any isn't Sendable. This PR removes the escape hatch by typing additionalClaims (and the init?(json:) parameter) as [String: any Sendable], so ActClaim gets real, compiler-checked Sendable conformance instead of an unchecked one.

  • Auth0/ActClaim.swift: ActClaim now conforms to Sendable (not @unchecked Sendable); additionalClaims and init?(json:) now use [String: any Sendable].
  • Auth0/UserProfile.swift: updated the act claim cast at the ActClaim(json:) call site to [String: any Sendable] to match the new initializer signature.

UserProfile.customClaims remains [String: Any]? (and UserProfile remains @unchecked Sendable) — out of scope for this fix.

📎 References

N/A

🎯 Testing

  • swift build succeeds with no errors.
  • swift test — full suite passes, no failures.
  • swiftlint lint — no new violations introduced by this change.

@NandanPrabhu @claude
fix: make ActClaim conform to Sendable instead of @unchecked Sendable
587d04a 
additionalClaims stored Any values, which aren't Sendable and forced the
@unchecked escape hatch. Typing it as [String: any Sendable] lets ActClaim
get real Sendable conformance checked by the compiler.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@NandanPrabhu NandanPrabhu requested a review from a team as a code owner July 3, 2026 12:53
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 036f58d1-0bed-4a26-8f22-7dcf833a0af1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/actclaim-sendable-conformance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NandanPrabhu

NandanPrabhu commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing this PR as we need to relook on mark few types to Sendable instead of @unchecked Sendable. This PR covers only the ActClaim but we have other types too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NandanPrabhu